Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix demo link #434

Merged
merged 2 commits into from
Mar 15, 2019
Merged

fix demo link #434

merged 2 commits into from
Mar 15, 2019

Conversation

jq
Copy link
Contributor

@jq jq commented Mar 15, 2019 •
edited by jlewi
Loading

change to correct link README.md

This change is Reviewable

@jq
fix demo link
2bd52c5 
change to correct link README.md
@k8s-ci-robot
Copy link

Hi @jq. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richardsliu
richardsliu reviewed Mar 15, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jq
The link should say README.md as well.
529fe1a 
The link should say README.md as well.
@richardsliu
Copy link
Contributor

/ok-to-test

@richardsliu
Copy link
Contributor

/lgtm

@richardsliu
Copy link
Contributor

/retest

1 similar comment
@jq
Copy link
Contributor Author

jq commented Mar 15, 2019

/retest

@richardsliu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 887f356 into kubeflow:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsliu richardsliu richardsliu left review comments

@garganubhav garganubhav Awaiting requested review from garganubhav

@jose5918 jose5918 Awaiting requested review from jose5918

Assignees

@richardsliu richardsliu

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jq @k8s-ci-robot @richardsliu